Review Request: Do not check if a wallpaper is a valid Plasma::Package

Raphael Kubo da Costa kubito at gmail.com
Fri May 6 07:17:13 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101302/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Do not check if the created Plasma::Package is valid.
    
Wallpapers consisting of a single image (without a .desktop metadata or anything else), usually obtained via GHNS, are not valid packages, but are valid wallpapers.
    
Commit b60136e, besides moving the loading code to a separate thread, also started checking if a given found path was also a valid package, which kept any wallpaper downloaded via the "get new wallpapers" button from being listed at all.


This addresses bug 269587.
    http://bugs.kde.org/show_bug.cgi?id=269587


Diffs
-----

  plasma/generic/wallpapers/image/backgroundlistmodel.cpp 3c92024 

Diff: http://git.reviewboard.kde.org/r/101302/diff


Testing
-------

All downloaded wallpapers are listed and selectable again.


Thanks,

Raphael

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110506/207a4132/attachment.htm 


More information about the Plasma-devel mailing list