Review Request: Fix build of libkdeclarative with ENABLE_FINAL.

[Nicolas Alvarez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101278/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

kdelibs compilation is broken with KDE4_ENABLE_FINAL turned ON. One of the problems is in libkdeclarative, where there's two file-static functions with the same name (ctor) and different code. These functions are used as function pointers when creating the QScript function objects.

Fixed by renaming the two functions to icon_ctor and url_ctor.


Diffs
-----

  experimental/libkdeclarative/bindings/icon.cpp 24885fa9d55b01388c681ec1766b659474fc40d7 
  experimental/libkdeclarative/bindings/url.cpp 21c7aa2227ea4ee10a15239905553bab40687fc5 

Diff: http://git.reviewboard.kde.org/r/101278/diff


Testing
-------

Compilation of kdelibs with and without final. Didn't try installing or running.


Thanks,

Nicolas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110502/e686f87d/attachment.htm