Review Request: Activity ResourceInstance class for API review
Ivan Čukić
ivan.cukic at kde.org
Mon May 2 17:14:08 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101273/#review3062
-----------------------------------------------------------
experimental/libkactivities/resourceinstance.h
<http://git.reviewboard.kde.org/r/101273/#comment2618>
The thing I don't like about the /empty/ constructor is that the user could thing the class will work if only some props or none are defined.
- Ivan
On May 2, 2011, 3:11 p.m., Ivan Čukić wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101273/
> -----------------------------------------------------------
>
> (Updated May 2, 2011, 3:11 p.m.)
>
>
> Review request for Nepomuk and Plasma.
>
>
> Summary
> -------
>
> Desc of the class is in the class apidocs
>
>
> Diffs
> -----
>
> experimental/libkactivities/resourceinstance.h PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/101273/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ivan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110502/244862ca/attachment.htm
More information about the Plasma-devel
mailing list