Review Request: Activity ResourceInstance class for API review

Ivan Čukić ivan.cukic at kde.org
Mon May 2 15:05:22 CEST 2011



> On May 2, 2011, 12:55 p.m., Marco Martin wrote:
> > experimental/libkactivities/ResourceInstance.h, line 77
> > <http://git.reviewboard.kde.org/r/101273/diff/1/?file=15799#file15799line77>
> >
> >     modified sounds a bit a signal name? maybe registerModification()?

register, notify... ? I don't know how to call it really


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101273/#review3044
-----------------------------------------------------------


On May 2, 2011, 12:50 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101273/
> -----------------------------------------------------------
> 
> (Updated May 2, 2011, 12:50 p.m.)
> 
> 
> Review request for Nepomuk, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian Trueg.
> 
> 
> Summary
> -------
> 
> Desc of the class is in the class apidocs
> 
> 
> Diffs
> -----
> 
>   experimental/libkactivities/ResourceInstance.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101273/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110502/cdcfc139/attachment-0001.htm 


More information about the Plasma-devel mailing list