Review Request: Don't create another timeline on every timeout refresh in Remember The Milk plasmoid

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101212/#review3021
-----------------------------------------------------------

Ship it!


- Marco


On May 1, 2011, 5:39 p.m., Alexey Chernov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101212/
> -----------------------------------------------------------
> 
> (Updated May 1, 2011, 5:39 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Summary
> -------
> 
> Currently RTM plasmoid creates new timeline on every refresh triggered by timeout (usually 5 minutes) of any action with tasks. Timeline is something like user session and every user action can be undone while still staying in the same timeline (http://www.rememberthemilk.com/services/api/timelines.rtm). I think, creating a new timeline on every refresh isn't so wise, especially as it triggeres the massive update of all the tasks and lists.
> 
> 
> Diffs
> -----
> 
>   dataengines/rememberthemilk/taskssource.cpp 06d354f9a6facfe8dc1ba42683078ab02ff39900 
> 
> Diff: http://git.reviewboard.kde.org/r/101212/diff
> 
> 
> Testing
> -------
> 
> The comment to the line of code says: "Allow us to get new information that people entered on the website or in another api". I tested the version without the line quite deeply performing task edits in both RTM web service and plasmoid and they were always synchronized with each other correctly (for plasmoid - as current timeout expired). So I see no reason in this.
> 
> 
> Thanks,
> 
> Alexey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110501/bb037291/attachment.htm