Review Request: KDevelop sessions runner

[Sebastian Kügler]

> On March 21, 2011, 2:45 p.m., Aaron J. Seigo wrote:
> > runners/kdevelopsessions/kdevelopsessions.cpp, lines 46-56
> > <http://git.reviewboard.kde.org/r/100903/diff/1/?file=12580#file12580line46>
> >
> >     to prevent krunner from waking up all the time, this should go into a slot connected to the prepare() signal; and then in a slot connected to teardown() delete the dirwatch.
> 
> Sebastian Kügler wrote:
>     Hm, not sure. The DirWatch only wakes up when kdevelop writes to the session files, which is "not that often", and given that the system is running at that point anyway, it won't cause unnecessary wakeups.
>     
>     When doing loadSessions() after krunner is pulled up, this touches disk and adds latency to krunner being available, so I'm not sure that's what we really want. (I can imagine delaying the first loading of sessions to the first teardown() appearance, though, to not unnecessarily touch disk on startup.)
>     
>     I've tried putting the new KDirWatch after prepare() and deleted it after teardown() signals, but got crashes in KDirWatch::addDir() after it's deleted once. I assume threading havoc here.

OK, found the crash, stupid me :)


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100903/#review2080
-----------------------------------------------------------


On March 22, 2011, 9:56 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100903/
> -----------------------------------------------------------
> 
> (Updated March 22, 2011, 9:56 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> New KRunner plugin listing kdevelop sessions. Based on the same code for kate, only changed the reading of the sessions.
> 
> 
> Diffs
> -----
> 
>   dataengines/kdecommits/plasma-engine-kdecommits.desktop 73125b1 
>   runners/CMakeLists.txt 7bcb05f 
>   runners/kdevelopsessions/CMakeLists.txt PRE-CREATION 
>   runners/kdevelopsessions/Messages.sh PRE-CREATION 
>   runners/kdevelopsessions/README PRE-CREATION 
>   runners/kdevelopsessions/kdevelopsessions.cpp PRE-CREATION 
>   runners/kdevelopsessions/kdevelopsessions.desktop PRE-CREATION 
>   runners/kdevelopsessions/kdevelopsessions.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100903/diff
> 
> 
> Testing
> -------
> 
> Started different sessions of kdevelop from KRunner, works just fine.
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110322/343ba303/attachment-0001.htm