Review Request: Expand last plugged device in Device Notifier applet

Aaron J. Seigo aseigo at kde.org
Mon Mar 21 17:16:57 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100904/#review2081
-----------------------------------------------------------

Ship it!


nice little improvement :)

- Aaron J.


On March 21, 2011, 4:06 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100904/
> -----------------------------------------------------------
> 
> (Updated March 21, 2011, 4:06 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Summary
> -------
> 
> This patch ensures that when a device is plugged, it appears expanded in the Device Notifier applet. This means only one click is necessary to trigger the device action.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/devicenotifier/devicenotifier.cpp 796a10b 
>   plasma/generic/applets/devicenotifier/notifierdialog.h a1cc81d 
>   plasma/generic/applets/devicenotifier/notifierdialog.cpp 84a0b9b 
> 
> Diff: http://git.reviewboard.kde.org/r/100904/diff
> 
> 
> Testing
> -------
> 
> - With only one device => device appears expanded.
> - With a collapsed device, plugged a new device => only new device appears expanded.
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110321/288695f6/attachment.htm 


More information about the Plasma-devel mailing list