Review Request: KDevelop sessions runner

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100903/#review2079
-----------------------------------------------------------


The README file looks... not updated :)


runners/kdevelopsessions/kdevelopsessions.cpp
<http://git.reviewboard.kde.org/r/100903/#comment1727>

    There are too many kWarnings, which cold just be turned into kDebug (maybe with properly registered debug area).



runners/kdevelopsessions/kdevelopsessions.cpp
<http://git.reviewboard.kde.org/r/100903/#comment1728>

    Maybe it would be better to delay the actual loadSession invocation by e.g. 1s or so, so when kdevelop writes the sessions the runner doesn't reach to every single change, but updates them in batch.



runners/kdevelopsessions/kdevelopsessions.h
<http://git.reviewboard.kde.org/r/100903/#comment1725>

    s/KATE/KDEVELOP/



runners/kdevelopsessions/kdevelopsessions.h
<http://git.reviewboard.kde.org/r/100903/#comment1726>

    The runner name must be fixed.


- Pino


On March 21, 2011, 12:51 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100903/
> -----------------------------------------------------------
> 
> (Updated March 21, 2011, 12:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> New KRunner plugin listing kdevelop sessions. Based on the same code for kate, only changed the reading of the sessions.
> 
> 
> Diffs
> -----
> 
>   runners/CMakeLists.txt 7bcb05f 
>   runners/kdevelopsessions/CMakeLists.txt PRE-CREATION 
>   runners/kdevelopsessions/Messages.sh PRE-CREATION 
>   runners/kdevelopsessions/README PRE-CREATION 
>   runners/kdevelopsessions/kdevelopsessions.cpp PRE-CREATION 
>   runners/kdevelopsessions/kdevelopsessions.desktop PRE-CREATION 
>   runners/kdevelopsessions/kdevelopsessions.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100903/diff
> 
> 
> Testing
> -------
> 
> Started different sessions of kdevelop from KRunner, works just fine.
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110321/8aa9508c/attachment.htm