Review Request: Support for offsets in temperature applet

Elvis Stansvik elvstone at gmail.com
Sat Mar 12 15:58:17 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100846/
-----------------------------------------------------------

(Updated March 12, 2011, 2:58 p.m.)


Review request for Plasma.


Changes
-------

Forgot copyright on temperature-offset-delegate.cpp.


Summary
-------

Hey guys. My first patch for plasma, so might be a bit rough. Suggestions welcome.

Hardware temperature sensors are often off by +/- a degrees from the actual temperature. This patch lets the user configure a constant offset for each temperature reading to compensate for this.

See attached screenshot.


Diffs (updated)
-----

  plasma/generic/applets/system-monitor/CMakeLists.txt b160c2f1ffaf2b02df688c9e736599cde98e21d3 
  plasma/generic/applets/system-monitor/temperature-offset-delegate.h PRE-CREATION 
  plasma/generic/applets/system-monitor/temperature-offset-delegate.cpp PRE-CREATION 
  plasma/generic/applets/system-monitor/temperature.h 049a80f9394b05b3f121a58fa200f99ce61f5ea0 
  plasma/generic/applets/system-monitor/temperature.cpp 16f06aa04c16eb1595cdbc79138c7ed0519c47dc 

Diff: http://git.reviewboard.kde.org/r/100846/diff


Testing
-------

- The temperatures in the visualization are correctly offset by the configured offsets.
- The offsets are correctly saved to plasma-desktop-appletsrc.


Screenshots
-----------

The UI for changing temperature offsets.
  http://git.reviewboard.kde.org/r/100846/s/97/


Thanks,

Elvis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110312/b0486dfa/attachment.htm 


More information about the Plasma-devel mailing list