Review Request: Editable KComboBox instead of KLineEdit with autocompletion box for the custom title setting in the folderview's config dialog

[Farhad Hedayati Fard]

> On March 10, 2011, 11:13 a.m., Aaron J. Seigo wrote:
> > plasma/applets/folderview/folderview.h, line 206
> > <http://git.reviewboard.kde.org/r/100834/diff/1/?file=10900#file10900line206>
> >
> >     unused?

Yeah, You're right :) removed this class member.


- Farhad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100834/#review1881
-----------------------------------------------------------


On March 10, 2011, 10:23 a.m., Farhad Hedayati Fard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100834/
> -----------------------------------------------------------
> 
> (Updated March 10, 2011, 10:23 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> IMO and As J Janz said in my previous review, using an editable KComboBox instead of a KLineEdit with completion box is a cleaner and less confusing approach for letting the user choose one of the predefined values for the title bar in the folderview's config dialog. I've edited the UI file and replaced the KLineEdit with a KComboBox, and used a KLineEdit for the LineEdit of this combobox as QLineEdit doesn't provide the clickMessage afaik.
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/folderview.h ef4e205 
>   plasma/applets/folderview/folderview.cpp 67f9ec0 
>   plasma/applets/folderview/folderviewDisplayConfig.ui 6568640 
> 
> Diff: http://git.reviewboard.kde.org/r/100834/diff
> 
> 
> Testing
> -------
> 
> Compiled and tested this patch, works fine here.
> 
> 
> Thanks,
> 
> Farhad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110310/a8fa5b92/attachment.htm