Review Request: Properly resize panel when screen resolution is lowered

Yuen Hoe Lim yuenhoe86 at gmail.com
Mon Mar 7 20:15:29 CET 2011


Yep, backported. Thanks for the link :)
----
Jason "moofang" Lim Yuen Hoe
http://yuenhoe.co.cc/



On Mon, Mar 7, 2011 at 8:47 PM, Sebastian Kügler <sebas at kde.org> wrote:

> On Saturday, March 05, 2011 11:12:39 Yuen Hoe Lim wrote:
> > > On March 5, 2011, 9:22 a.m., Aaron J. Seigo wrote:
> > > > nice fix; i have a feeling this code could be simplified somewhat,
> but
> > > > let's cover all the corner cases first.
> > > >
> > > > the issue you note about setting the size in a larger resolution and
> > > > then switching back to a smaller one is an interesting one indeed.
> the
> > > > goal was (and i stress _was_, as we can alter this :) to allow
> > > > per-resolution panel settings. but as you note, that may not indeed
> be
> > > > what is wanted/expected all the time.
> > > >
> > > > for now, in terms of fixing this stuff up for 4.6.2, i don't think we
> > > > need to address it. but for 4.7 it might be nice to lay down some
> > > > arbitrary "rules" for panel sizing between resolution changes that
> > > > keeps some flexibility and obeys "least surprise" as much as possible
> > > > and (re-?)write this code to match those rules.
> >
> > Thanks. Pushed to master. Umm, is there something else I need to do in
> > order for this to appear in 4.6.2?
>
> Yes, you need to backport it to the 4.6 branch, see
> http://techbase.kde.org/Development/Tutorials/Git/Recipes
>
> Cheers,
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110308/658561b5/attachment.htm 


More information about the Plasma-devel mailing list