Review Request: Properly resize panel when screen resolution is lowered

Marco Martin notmart at gmail.com
Sat Mar 5 11:14:47 CET 2011


On Saturday 05 March 2011, Yuen Hoe Lim wrote:
> > On March 5, 2011, 9:22 a.m., Aaron J. Seigo wrote:
> > > nice fix; i have a feeling this code could be simplified somewhat, but
> > > let's cover all the corner cases first.
> > > 
> > > the issue you note about setting the size in a larger resolution and
> > > then switching back to a smaller one is an interesting one indeed. the
> > > goal was (and i stress _was_, as we can alter this :) to allow
> > > per-resolution panel settings. but as you note, that may not indeed be
> > > what is wanted/expected all the time.
> > > 
> > > for now, in terms of fixing this stuff up for 4.6.2, i don't think we
> > > need to address it. but for 4.7 it might be nice to lay down some
> > > arbitrary "rules" for panel sizing between resolution changes that
> > > keeps some flexibility and obeys "least surprise" as much as possible
> > > and (re-?)write this code to match those rules.
> 
> Thanks. Pushed to master. Umm, is there something else I need to do in
> order for this to appear in 4.6.2?

checkout KDE/4.6 and then cherry pick the sha1 hash of that commit in that 
branch

Cheers,
Marco Martin


More information about the Plasma-devel mailing list