[kdelibs] plasma: after applet's dataupdated is called, dirty=false

[Marco Martin]

On Thursday 03 March 2011, Aaron J. Seigo wrote:
> On Wednesday, March 2, 2011, Marco Martin wrote:
> > Git commit 87c356421fdf4587fa8b82a3f148e9bad2fa5edb by Marco Martin.
> > Committed on 02/03/2011 at 22:04.
> > Pushed by mart into branch 'master'.
> > 
> > after applet's dataupdated is called, dirty=false
> > 
> > in DataEnginePrivate::connectSource, if it's an immediate call, and
> > QMetaObject::invokeMethod(visualization, "dataUpdated" is called, means
> > the datacontainers' dirty bit must be set to false, otherwise we will get
> > two subsequent dataUpdated
> > 
> > can it have countereffects?
> 
> it's _probably_ safe, but this is moderately intricate (if not overly
> complex) code. have you tried it with both synchronous and asynchronous
> (e.g. weather) dataengines?

i didn't find any counter effect, with sync and async engines...
will still keep an eye on it

and should definitely get around adding some tests for that in the testengine 
thing.

Cheers,
Marco Martin