Review Request: Option to set no title for the folderview applet

[Farhad Hedayati Fard]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100750/
-----------------------------------------------------------

(Updated March 3, 2011, 1:39 p.m.)


Review request for Plasma.


Changes
-------

removed the UI option, now an autocompletion box is opened whenever the user wants to edit the title, it has three values :

* Empty
* Default title
* Full path 

If the user enters nothing (labelEdit.isEmpty()) "Empty" is used but the text of labelEdit is changed to "Empty" next time the user opens the config dialog.
Also, If "Default title" or "Full path" is chosen, labelEdit shows these values instead of the actual default title or full path...


Summary
-------

Let the user set a blank label. The label should not take up any space when it is blank.


Diffs (updated)
-----

  plasma/applets/folderview/folderview.h 2241b12 
  plasma/applets/folderview/folderview.cpp f604277 

Diff: http://git.reviewboard.kde.org/r/100750/diff


Testing
-------

Works fine here! 


Screenshots
-----------

folderview configuration dialog
  http://git.reviewboard.kde.org/r/100750/s/84/
folderview with blank label
  http://git.reviewboard.kde.org/r/100750/s/85/


Thanks,

Farhad

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110303/0ef1c195/attachment.htm