[kdelibs] plasma: after applet's dataupdated is called, dirty=false

Marco Martin notmart at gmail.com
Wed Mar 2 22:09:19 CET 2011


Git commit 87c356421fdf4587fa8b82a3f148e9bad2fa5edb by Marco Martin.
Committed on 02/03/2011 at 22:04.
Pushed by mart into branch 'master'.

after applet's dataupdated is called, dirty=false

in DataEnginePrivate::connectSource, if it's an immediate call, and QMetaObject::invokeMethod(visualization, "dataUpdated" is called, means the datacontainers' dirty bit must be set to false, otherwise we will get two subsequent dataUpdated

can it have countereffects?

CCMAIL:plasma-devel at kde.org

M  +1    -0    plasma/dataengine.cpp     

http://commits.kde.org/kdelibs/87c356421fdf4587fa8b82a3f148e9bad2fa5edb

diff --git a/plasma/dataengine.cpp b/plasma/dataengine.cpp
index b28658f..7be42f9 100644
--- a/plasma/dataengine.cpp
+++ b/plasma/dataengine.cpp
@@ -671,6 +671,7 @@ void DataEnginePrivate::connectSource(DataContainer *s, QObject *visualization,
         QMetaObject::invokeMethod(visualization, "dataUpdated",
                                   Q_ARG(QString, s->objectName()),
                                   Q_ARG(Plasma::DataEngine::Data, s->data()));
+        s->d->dirty = false;
     }
 }
 


More information about the Plasma-devel mailing list