Review Request: Option to set no title for the folderview applet

[Farhad Hedayati Fard]

> On Feb. 28, 2011, 3:45 p.m., Sebastian Kügler wrote:
> > There's no need to add a UI option for this, the user should just be able to set an empty title and the header would then get hidden / collapsed.
> > 
> > Right now, this doesn't happen since when the label is empty, the default gets chosen. So this mechanism needs to be a bit smarter to detect when the user has actually set an empty title (which is different from title.isEmpty() so set default name).

How should I know whether the user has set the title empty to make the header hidden or by doing so he/she means to choose the default title instead of being hidden? I think It either needs a UI option or some special value in the custom title... 
Maybe I don't get what you're saying, can you please explain a little more? 
Thanks :)


- Farhad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100750/#review1698
-----------------------------------------------------------


On Feb. 26, 2011, 5:13 p.m., Farhad Hedayati Fard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100750/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2011, 5:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Let the user set a blank label. The label should not take up any space when it is blank.
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/folderview.h 2241b12 
>   plasma/applets/folderview/folderview.cpp f604277 
>   plasma/applets/folderview/folderviewDisplayConfig.ui 6568640 
> 
> Diff: http://git.reviewboard.kde.org/r/100750/diff
> 
> 
> Testing
> -------
> 
> Works fine here! 
> 
> 
> Screenshots
> -----------
> 
> folderview configuration dialog
>   http://git.reviewboard.kde.org/r/100750/s/84/
> folderview with blank label
>   http://git.reviewboard.kde.org/r/100750/s/85/
> 
> 
> Thanks,
> 
> Farhad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110301/030d4ab3/attachment.htm