Review Request: Add support for building libplasma with GLES2

[Jammy Zhou]

Hi Sebas,

As Martin mentioned, the direct GL dependency has been removed in my new
patch, and the original "BUILD_PLASMA_WITH_OPENGLES" option I added is not
needed any more in this case.

Cheers,
Jammy

On Mon, Feb 28, 2011 at 11:33 PM, Martin Gräßlin <mgraesslin at kde.org> wrote:

>
> ----- Ursprüngliche Mitteilung -----
> > On Friday, February 25, 2011 04:29:36 Jammy Zhou wrote:
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > http://git.reviewboard.kde.org/r/100705/
> > > -----------------------------------------------------------
> > > Update the patch to remove direct OpenGL dependency for libplasma. The
> > > OpenGL usage in libplasma should better go through libQtOpenGL,which
> > > can be enabled for desktop OpenGL or OpenGL ES2.0
> > >
> > > Summary
> > > -------
> > >
> > > After build kwin with GLES2 code path, the kwin binary still has
> > > dependency on libGL.so, which is introduced by libplasma.so. Then we
> > > also need to add GLES2 support to libplasma, so that kwin/plasma only
> > > has dependency on libGLESv2.so in this case.
> > >
> > > The new option "BUILD_PLASMA_WITH_OPENGLES" added in attached patch is
> > > disabled by default, and distributions can turn it on when do packaging
> > > for OpenGL ES2.0 support.
> >
> > Shouldn't that option cover both, kwin and plasma? Or are there serious
> > cases   where you'd want one, but not the other on opengl-es? If not,
> > let's merge them   to prevent building and packaging headaches.
> First of all: the problem has been solved by removing the libGL dependency
> from libplasma.
>
> Now to the other question: yes there are cases for having kwin with gles
> and plasma with gl. kwin will start to focus on gles only (wayland) while
> there is no reason for Plasma to restrict on the gles api.
>
> Cheers
> Martin
> >
> > Cheers,
> > --
> > sebas
> >
> > http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
> > _______________________________________________
> > Plasma-devel mailing list
> > Plasma-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110301/5f55e855/attachment.htm