Review Request: Use underscore instead of hyphen in .so name

Aaron J. Seigo aseigo at kde.org
Wed Jun 29 11:32:46 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101801/#review4254
-----------------------------------------------------------


yes, it's unfortunately inconsistent. however, is there any particular reason to change it at this point, other than to improve said consistency? if not, i'm not sure it's worth doing.

- Aaron J.


On June 29, 2011, 12:39 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101801/
> -----------------------------------------------------------
> 
> (Updated June 29, 2011, 12:39 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Every other applet uses "plasma_applet_name.so", but systemloadviewer uses "plasma-applet_name.so". This should fix it, but I don't know if I can safely change the .so name.
> 
> 
> Diffs
> -----
> 
>   applets/systemloadviewer/CMakeLists.txt 6de867a 
>   applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 5311d2c 
> 
> Diff: http://git.reviewboard.kde.org/r/101801/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110629/49700472/attachment-0001.htm 


More information about the Plasma-devel mailing list