Review Request: plasma-windowed: Quit on closeEvent not on hideEvent

[David Palacio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101802/#review4239
-----------------------------------------------------------



plasma/generic/shells/plasma-windowed/singleview.cpp
<http://git.reviewboard.kde.org/r/101802/#comment3478>

    I think the deleteLater() call should stay. Maybe after QGraphicsView::closeEvent()?


- David


On June 29, 2011, 2:19 a.m., David Palacio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101802/
> -----------------------------------------------------------
> 
> (Updated June 29, 2011, 2:19 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The view deletes itself when a hideEvent (QWidget) is sent. This is wrong as minimization and desktop switches send this kind of event.
> 
> 
> This addresses bug 253153.
>     http://bugs.kde.org/show_bug.cgi?id=253153
> 
> 
> Diffs
> -----
> 
>   plasma/generic/shells/plasma-windowed/singleview.h ba9e767 
>   plasma/generic/shells/plasma-windowed/singleview.cpp da87cf8 
> 
> Diff: http://git.reviewboard.kde.org/r/101802/diff
> 
> 
> Testing
> -------
> 
> Tested on KDE 4.6.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110629/2875b976/attachment.htm