Review Request: Fix bug 276082 and refactor timeline in plasmate

Etienne Rebetez etienne.rebetez at oberwallis.ch
Wed Jun 22 21:37:58 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101728/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Hi,

When trying out plasmate the last day, i was hit with the bug 276082. Since i didn't want that it happens to someone else, i made a fix for it.
I the process i found that the loadTimeLine function was far to big. So i did also some refactoring. (this diff is kinda huge but i made the changes in a branch which i can merge to master)
The timeliene and savepoint creation should now behave as expected.

Let me know what you think.
Etienne

PS: How is the commit policy in plasmate? Could i just push directly to master in the future?


Diffs
-----

  mainwindow.cpp 8326a29 
  savesystem/timeline.h 719fb73 
  savesystem/timeline.cpp d258a1a 
  savesystem/timelineitem.h 1e9699f 
  savesystem/timelineitem.cpp d9b0a67 

Diff: http://git.reviewboard.kde.org/r/101728/diff


Testing
-------


Thanks,

Etienne

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110622/22ad6c66/attachment.htm 


More information about the Plasma-devel mailing list