Review Request: Plasmate:perform a success check code added

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101584/#review4041
-----------------------------------------------------------


see my comment on the other review request. in fact, i'm going to close this one in favor of the other one.


projectmanager/projectmanager.cpp
<http://git.reviewboard.kde.org/r/101584/#comment3299>

    spaces after commas :)



projectmanager/projectmanager.cpp
<http://git.reviewboard.kde.org/r/101584/#comment3300>

    looks like this isn't properly aligned?



projectmanager/projectmanager.cpp
<http://git.reviewboard.kde.org/r/101584/#comment3301>

    watch indentation!



projectmanager/projectmanager.cpp
<http://git.reviewboard.kde.org/r/101584/#comment3302>

    preferable this should become:
    
    if (code == KMessageBox::Continue) {
        removeProcess();
    }
    



projectmanager/projectmanager.cpp
<http://git.reviewboard.kde.org/r/101584/#comment3303>

    if (


- Aaron J.


On June 11, 2011, 4:38 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101584/
> -----------------------------------------------------------
> 
> (Updated June 11, 2011, 4:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> hello,
> 
> the need for the patch is coming from this todo "TODO: should perform a success check here instead of assuming success."
> The patch shares some code with this one ( git.reviewboard.kde.org/r/101535/).
> 
> 
> Diffs
> -----
> 
>   projectmanager/projectmanager.h 2c5bff2 
>   projectmanager/projectmanager.cpp c00fd27 
> 
> Diff: http://git.reviewboard.kde.org/r/101584/diff
> 
> 
> Testing
> -------
> 
> compiles without issues.tested be my
> 
> 
> Thanks,
> 
> Giorgos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110620/185f71ea/attachment.htm