Review Request: Plasmate:make plasmate remember the last checked qdockwidgets

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101582/#review4043
-----------------------------------------------------------


this patch didn't get uploaded fully; please re-submit. the part that did get submitted is full of crashes, however.


mainwindow.cpp
<http://git.reviewboard.kde.org/r/101582/#comment3307>

    the check in the if statement above means that in this else, m_previewerWidget is NULL and so this will crash!



mainwindow.cpp
<http://git.reviewboard.kde.org/r/101582/#comment3306>

    isn't this duplicated with the code that immediately follows?



mainwindow.cpp
<http://git.reviewboard.kde.org/r/101582/#comment3305>

    simpler as:
    
    setNotesVisible(m_notesWidget);



mainwindow.cpp
<http://git.reviewboard.kde.org/r/101582/#comment3308>

    crash.



mainwindow.cpp
<http://git.reviewboard.kde.org/r/101582/#comment3309>

    crash.



mainwindow.cpp
<http://git.reviewboard.kde.org/r/101582/#comment3310>

    seems highly duplicated and could simply be setFileListVisible(m_editWidget)


- Aaron J.


On June 18, 2011, 6:30 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101582/
> -----------------------------------------------------------
> 
> (Updated June 18, 2011, 6:30 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Summary
> -------
> 
> hello,
> 
> since now plasmate wasn't able to remember the last used qdockwidgets,except from 1 or 2.
> With this patch,it (plasmate) is able to remember the last state of the qdockwidgets and also the size of the mainwindow (maximized or not).
> The drawback is that when the plasmate will start for the first time it will be a bit too populated since all the qdockwidgets will be checked.
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp 8326a29 
>   startpage.cpp 3d5f765 
> 
> Diff: http://git.reviewboard.kde.org/r/101582/diff
> 
> 
> Testing
> -------
> 
> compiles fine without issues and regressions.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110620/0612fe8c/attachment-0001.htm