Review Request: Code review for the newspaper containment

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101543/#review4039
-----------------------------------------------------------


it looks good except for one spot that changes behaviour (comment inline below)


plasma/containments/newspaper/appletscontainer.cpp
<http://git.reviewboard.kde.org/r/101543/#comment3297>

    this is not equivalent. it means that if there is no containment, calling setExpandAll will do nothing, not even record the expected setting.


- Aaron J.


On June 8, 2011, 1:23 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101543/
> -----------------------------------------------------------
> 
> (Updated June 8, 2011, 1:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> While tracking down some problems in the Newspaper containment problems I decided to simplify a little its code. I think this makes it a little more readable.
> 
> Hope that helps.
> 
> 
> Diffs
> -----
> 
>   plasma/containments/newspaper/appletscontainer.cpp 1ba4d83 
> 
> Diff: http://git.reviewboard.kde.org/r/101543/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110620/0a08a78b/attachment-0001.htm