Review Request: Plasmate:qcheckbox added and the removal buttons became more intellect.

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101585/#review3928
-----------------------------------------------------------


some remarks in here, some also apply to your other request.

Tip: If you create a request that "overrides" an older one, remove the older one :)


projectmanager/projectmanager.cpp
<http://git.reviewboard.kde.org/r/101585/#comment3207>

    seems indentation is screwed here: use 4 spaces



projectmanager/projectmanager.cpp
<http://git.reviewboard.kde.org/r/101585/#comment3208>

    shouldn't this just disable the button?
    
    Also, space after comma



projectmanager/projectmanager.cpp
<http://git.reviewboard.kde.org/r/101585/#comment3209>

    If no project is selected, simply disable() the button in question. Makes it immediately clear.
    
    In general, whenever you use a KMessageBox, think if you can prevent the situation from appearing, as those popups are generally disturbing to the user and should be avoided by leading the user through the UI.


- Sebastian


On June 11, 2011, 5:03 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101585/
> -----------------------------------------------------------
> 
> (Updated June 11, 2011, 5:03 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> hello,
> 
> the following patch is a summary of some other patches that i had to my local repository.Because it is too difficult to make different request due to share code i made 1 review request.(Sorry for the inconvinience.)
> 
> This patch shares code with these two.
> git.reviewboard.kde.org/r/101535/
> git.reviewboard.kde.org/r/101584/
> 
> The patch adds a Qcheckbox which enables the user to protect one project from the removal.
> Also the delete buttons were able to be used even if a project wasn't selected at all,with this patch not anymore.
> 
> The code lacks only in the storage possibility.Plasmate is not able to "remember" which projects are selected or not,i will fix this later.
> 
> P.S.:i created the checkbox with some intelligence in order to work only when it is supposed to work.For example,only when the user selects a project.
> 
> 
> Diffs
> -----
> 
>   projectmanager/projectmanager.h 2c5bff2 
>   projectmanager/projectmanager.cpp c00fd27 
> 
> Diff: http://git.reviewboard.kde.org/r/101585/diff
> 
> 
> Testing
> -------
> 
> compiles fines,tested by me.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110616/93b20864/attachment.htm