Review Request: Changes at the functionality of the delete button.

Giorgos Tsiapaliwkas terietor at gmail.com
Tue Jun 7 17:24:39 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101535/
-----------------------------------------------------------

(Updated June 7, 2011, 3:24 p.m.)


Review request for Plasma.


Changes
-------

i added a new diff file,because the reviewboard wasn't able to export the previous one.


Summary
-------

Hello,

after a discussion with Aaron Seigo at the #plasma we decided to add a new button at the project manager which is named "Remove Project From List",which deletes the project only from the list(not from disk).The delete button was renamed to "Remove Project From Disk".Also i consider it properly to change the names of some function in order to be more relative with the buttons names.As well i changed and the functionality of confirmdeletion() in order to avoid using the same code twice.


Diffs (updated)
-----

  projectmanager/projectmanager.h 2c5bff2 
  projectmanager/projectmanager.cpp c00fd27 

Diff: http://git.reviewboard.kde.org/r/101535/diff


Testing
-------

compiles and runs without regressions.
tested by me.


Thanks,

Giorgos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110607/93279a7c/attachment.htm 


More information about the Plasma-devel mailing list