Review Request: Plasmate:void ProjectManager::removeDirectory works correctly

[Giorgos Tsiapaliwkas]

> On July 19, 2011, 10:50 p.m., Aaron J. Seigo wrote:
> > projectmanager/projectmanager.cpp, lines 107-109
> > <http://git.reviewboard.kde.org/r/101550/diff/3/?file=27486#file27486line107>
> >
> >     so now it will _only_ delete local projects?
> >     
> >     or even worse: if you have a project with the same name as a local project, it will delete the local one.
> >     
> >     what should be done is to see if the project _is_ a local project (e.g. the project starts with KStandardDirs::locateLocal("appdata", "/")) and if so do not do the cd("..") in deleteProject.

So,you want plasmate to delete also projects that are not local(~/.kde4)?
Yes if the project is not a local one,the cd("..") is useless.Also plasmate has to check if a project is local or not,before it does "const QString project = KStandardDirs::locateLocal("appdata",recentProject + "/");".correct?


- Giorgos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101550/#review4878
-----------------------------------------------------------


On July 19, 2011, 11 a.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101550/
> -----------------------------------------------------------
> 
> (Updated July 19, 2011, 11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Hello,
> 
> the method removeDirectory wasn't removing the parent folder. 
> For example,if we named out plasmoid my_plasmoid it would have a directory like this "$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/my_plasmoid" and the after calling the removeDirectory(before the patch) method we would have a directory like this:
> ""$(kde4-config --localprefix)/share/apps/plasmate/my_plasmoid/NOTES".
> With the patch the entire folder my_plasmoid is being deleted.
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp e08581f 
>   projectmanager/projectmanager.h 53ef226 
>   projectmanager/projectmanager.cpp 122e48d 
> 
> Diff: http://git.reviewboard.kde.org/r/101550/diff
> 
> 
> Testing
> -------
> 
> compiles without issues and without regressions.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110720/dde7e0e0/attachment.htm