Review Request: Plasmate:qcheckbox added and the removal buttons became more intellect.

Giorgos Tsiapaliwkas terietor at gmail.com
Thu Jul 7 23:35:26 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101585/
-----------------------------------------------------------

(Updated July 7, 2011, 9:35 p.m.)


Review request for Plasma.


Changes
-------

changes:
-qcheckbox code removed
-KMenu added
-smart reaction,on the number of the selected projects


Summary
-------

hello,

the following patch is a summary of some other patches that i had to my local repository.Because it is too difficult to make different request due to share code i made 1 review request.(Sorry for the inconvinience.)

This patch shares code with these two.
git.reviewboard.kde.org/r/101535/
git.reviewboard.kde.org/r/101584/

The patch adds a Qcheckbox which enables the user to protect one project from the removal.
Also the delete buttons were able to be used even if a project wasn't selected at all,with this patch not anymore.

The code lacks only in the storage possibility.Plasmate is not able to "remember" which projects are selected or not,i will fix this later.

P.S.:i created the checkbox with some intelligence in order to work only when it is supposed to work.For example,only when the user selects a project.


Diffs (updated)
-----

  projectmanager/projectmanager.h d24ef19 
  projectmanager/projectmanager.cpp 8c0526b 

Diff: http://git.reviewboard.kde.org/r/101585/diff


Testing
-------

compiles fines,tested by me.


Thanks,

Giorgos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110707/0bb6fd7b/attachment.htm 


More information about the Plasma-devel mailing list