Review Request: Plasmate:make plasmate remember the last checked qdockwidgets

Aaron J. Seigo aseigo at kde.org
Wed Jul 6 15:19:04 CEST 2011



> On July 3, 2011, 6:37 p.m., Giorgos Tsiapaliwkas wrote:
> > After Aaron's patches,the qdockwidgets are working completly differently so this patch is useless.
> > However,how would you like the plasmate to handle the qdockwidgets?
> > Do you want to rewrite this patch?
> > If yes,which dockwidgets do you want to be visible at the first time that someone creates a project?

no, my fixes make this patch redundant, actually.

the dockwidets which are visible the first time are the file list and the previewer (if any), and this is also implemented now.

so i consider this "done" ...


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101582/#review4356
-----------------------------------------------------------


On June 18, 2011, 6:30 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101582/
> -----------------------------------------------------------
> 
> (Updated June 18, 2011, 6:30 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Summary
> -------
> 
> hello,
> 
> since now plasmate wasn't able to remember the last used qdockwidgets,except from 1 or 2.
> With this patch,it (plasmate) is able to remember the last state of the qdockwidgets and also the size of the mainwindow (maximized or not).
> The drawback is that when the plasmate will start for the first time it will be a bit too populated since all the qdockwidgets will be checked.
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp 8326a29 
>   startpage.cpp 3d5f765 
> 
> Diff: http://git.reviewboard.kde.org/r/101582/diff
> 
> 
> Testing
> -------
> 
> compiles fine without issues and regressions.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110706/a3fb9180/attachment.htm 


More information about the Plasma-devel mailing list