Review Request: Plasmate:fixes a bug in project manager(startpage)

Giorgos Tsiapaliwkas terietor at gmail.com
Wed Jul 6 15:14:38 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101840/#review4462
-----------------------------------------------------------


due to share code the review will be close.
For the code please go to https://git.reviewboard.kde.org/r/101585/diff/#index_header

- Giorgos


On July 3, 2011, 6:13 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101840/
> -----------------------------------------------------------
> 
> (Updated July 3, 2011, 6:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> hello,
> 
> after the recent patches that has been sended to plasmate,one of them was hiding permantly the project manager's ui (recent project list) this patch fixes the issue.Also after asking at the #plasma some devs told me that the plasma's coding style is the one of kdelibs,so i decided to also change the coding style of the included libraries.Is this ok??
> 
> p.s.:Now that my exams ended,i will take a look in my other patches as well.
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp a6948e3 
>   projectmanager/projectmanager.cpp b8baf1a 
>   startpage.h 6d45e02 
>   startpage.cpp dd39c97 
> 
> Diff: http://git.reviewboard.kde.org/r/101840/diff
> 
> 
> Testing
> -------
> 
> compiles and runs
> 
> 
> Thanks,
> 
> Giorgos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110706/4343b186/attachment.htm 


More information about the Plasma-devel mailing list