Review Request: Make the timer plasmoid text-based rather than SVG-based.

Tadeusz Andrzej Kadlubowski yess at hell.org.pl
Fri Jan 28 17:56:57 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6420/
-----------------------------------------------------------

Review request for Plasma and Davide Bettio.


Summary
-------

Currently the timer plasmoid uses prerendered fonts packaged as a SVG theme. This ignores user preferences related to fonts, and looks out of place, when this plasmoid is used just next to a digital clock plasmoid.

The goal of this patch is to make this plasmoid look the same as the timer plasmoid. Uniformity is a nice polish.

This is a work in progress. TODOs:
- Font sizing is not ready;
- The SVG theme is to be thrown away;
- Font choice in the configuration dialog.


Diffs
-----

  /trunk/KDE/kdeplasma-addons/applets/timer/timer.h 1217778 
  /trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp 1217778 
  /trunk/KDE/kdeplasma-addons/applets/timer/timerdigit.h 1217778 
  /trunk/KDE/kdeplasma-addons/applets/timer/timerdigit.cpp 1217778 

Diff: http://svn.reviewboard.kde.org/r/6420/diff


Testing
-------

Compiles cleanly. Works well on KDE 4.5.4.

Setting timer with scroll wheel still works.
Changing color to red still works.
Notifications still work.


Thanks,

Tadeusz Andrzej

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110128/59f381ee/attachment.htm 


More information about the Plasma-devel mailing list