Review Request: Adding "Set Wallpaper Image" Option in Picture Frame

[todd rme]

On Wed, Jan 26, 2011 at 11:20 AM, Sinny Kumari <ksinny at gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6416/
>   Review request for Plasma.
> By Sinny Kumari.
> Description
>
> Including this patch and other two (http://svn.reviewboard.kde.org/r/6375/ , http://reviewboard.kde.org/r/6391/ ) , It adds "Set Wallpaper Image" feature in Picture Frame. If the User right clicks on Picture Frame, there will be an option "Set Wallpaper Image". This Option will set the current Image Of Picture
> Frame as Wallpaper Image.
>
>   Testing
>
> Setting Picture Frame Image as wallpaper Image in all cases. Added QTimer in method Frame::setImageAsWallpaper() in Order to work properly in case of Wallpaper other than Image and Slideshow. If there is better solution than using QTimer, please suggest :)
>
>   Diffs
>
>    - trunk/KDE/kdeplasma-addons/applets/frame/frame.h (1216449)
>    - trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp (1216449)
>
> View Diff <http://svn.reviewboard.kde.org/r/6416/diff/>
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>

I see one issue with this approach: it hard-codes how to deal with different
plugins.  What happens to the weather wallpaper?  What happens to wallpaper
clock or day/night wallpaper?  What if someone writes their own version of
the slideshow plugin?  Is someone going to rewrite this every time a new
plugin is developed?

Might it be a better approach to have some general API for setting images to
a wallpaper?  The plugin would set up its own method of dealing with the
pictures sent to it (which could include ignoring it).  The the default
plugin and virus plugin would just set the image, the slideshow plugin would
add it to the list, the weather plugin would set it to the current weather
condition, the day/night and clock plugins would set it to the current time.

As a fall-back, if the plugin does not support the API, plasma would change
to the normal wallpaper image and use the image there.  So plugins that
don't use images, like marble and mandelbrot, could just not implement that
API, in which case selecting an image would change to the default plugin and
then set the image to that.

This also has the benefit that other widgets would also be able to hook into
this and change the wallpaper without much work and without worrying about
what plugin is being used.

-Todd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110126/6e8bd8b2/attachment.htm