Review Request: Overrides Plasma::wallpaer method addUrls() to set Image

[Aaron Seigo]

> On Jan. 21, 2011, 3:25 p.m., Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp, lines 140-141
> > <http://svn.reviewboard.kde.org/r/6391/diff/1/?file=44401#file44401line140>
> >
> >     if it is running as a slideshow, it should probably add all of the urls to the slideshow (not just the first one) and start showing the first of them.
> 
> Sinny Kumari wrote:
>     Since the option in Frame applet says that "Set Wallpaper", so only that image should be set as wallpaper and in "SingleImage" mode. According to me if "Picture Frame" and "wallpaper" both are in Slideshow mode, it should not add all Url to the slideshow. Only the current picture from the Picture Frame should be set as wallpaper and mode should be set to SingleImage.

imagine you are the user with a slideshow setup with 12 of your favorite images.

you select "Set as wallpaper" from the frame.

which result would surprise you the least? make you the happiest? make you most impressed with plasma?


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6391/#review9669
-----------------------------------------------------------


On Jan. 21, 2011, 5:52 a.m., Sinny Kumari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6391/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2011, 5:52 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
>  Method addUrls(const KUrl::List &urls) which is protected Q_SLOTS will override the method defined ( changes that have been made in http://svn.reviewboard.kde.org/r/6375/ ) in the base class Plasma::wallpaper to set Image. After reviewing it I will implement both changes in Frame Applet :)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 1215563 
>   trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1215563 
> 
> Diff: http://svn.reviewboard.kde.org/r/6391/diff
> 
> 
> Testing
> -------
> 
> Tested in trunk and it works perfectly.
> 
> 
> Thanks,
> 
> Sinny
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110124/68df30a9/attachment.htm