Review Request: Overrides Plasma::wallpaer method addUrls() to set Image
Aaron Seigo
aseigo at kde.org
Fri Jan 21 16:25:13 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6391/#review9669
-----------------------------------------------------------
trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp
<http://svn.reviewboard.kde.org/r/6391/#comment10777>
if it is running as a slideshow, it should probably add all of the urls to the slideshow (not just the first one) and start showing the first of them.
- Aaron
On Jan. 21, 2011, 5:52 a.m., Sinny Kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6391/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2011, 5:52 a.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Method addUrls(const KUrl::List &urls) which is protected Q_SLOTS will override the method defined ( changes that have been made in http://svn.reviewboard.kde.org/r/6375/ ) in the base class Plasma::wallpaper to set Image. After reviewing it I will implement both changes in Frame Applet :)
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 1215563
> trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1215563
>
> Diff: http://svn.reviewboard.kde.org/r/6391/diff
>
>
> Testing
> -------
>
> Tested in trunk and it works perfectly.
>
>
> Thanks,
>
> Sinny
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110121/a3cbb90f/attachment.htm
More information about the Plasma-devel
mailing list