Review Request: Mime-type in NepomukSearchRunner

[Amir Pakdel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6338/
-----------------------------------------------------------

(Updated Jan. 17, 2011, 4:50 a.m.)


Review request for Plasma, Sebastian Trueg and Vishesh Handa.


Changes
-------

some code style changes


Summary
-------

I have changed NepomukSearchRunner a little bit, so I could search for contents of notes (added by BasketNotepad) using KRunner.

It uses NIE:mimeType of the resource to set the "type" and "iconName" of the search result. If the resourse does not have NIE:mimeType property, KMimeType::findByUrl(url) is used instead (in order to find the mime-type associated with the url of the resource).

When running/opening the search result, preferredService of the mime-type is used in invokation of KRun::run; therefore, the mime-type of the resource (or its url) indicates the service that would be used to run the resource.


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp 1193800 
  /trunk/KDE/kdebase/workspace/plasma/generic/runners/nepomuksearch/queryclientwrapper.cpp 1193800 

Diff: http://svn.reviewboard.kde.org/r/6338/diff


Testing
-------

I have searched for contents of notes that were added by BasketNotepad (using KRunner) and opened them in BasketNotepads.


Thanks,

Amir

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110117/a79273d0/attachment.htm