Review Request: ClockApplet : show seconds in the tooltip
Aaron Seigo
aseigo at kde.org
Sat Jan 15 21:08:57 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6336/#review9635
-----------------------------------------------------------
i agree with Marco, that this should end up in the ClockApplet class shared by all clocks.
the way this probably will need to be done is to have a QObject with a dataUpdated method used for this purpose in ClockApplet that is connected/disconnected to the time engine using the current timezone on toolTipAboutToShow/Hide. then it will work with all clocks.
- Aaron
On Jan. 15, 2011, 3:17 p.m., Iamluc wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6336/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2011, 3:17 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Hi,
>
> When using a clock applet, seconds are often not visibles. But sometimes you need them.
> This patch shows them in the tooltip of the applet.
>
> Analog-clock has been updated to refresh the tooltip every seconds.
> If this change is accepted, I could change digital-clock
>
> Thanks !
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 1214556
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h 1214556
> /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp 1214556
>
> Diff: http://svn.reviewboard.kde.org/r/6336/diff
>
>
> Testing
> -------
>
> It Works on plasmoidviewer and with a real session
>
>
> Thanks,
>
> Iamluc
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110115/f3485b45/attachment.htm
More information about the Plasma-devel
mailing list