Review Request: ClockApplet : show seconds in the tooltip

[Iamluc]

> On Jan. 15, 2011, 3:21 p.m., Marco Martin wrote:
> > an issue i see with this patch is that it would force to update from the time engine every half a secons:
> > this means more cpu wakeups, more repaints -> less battery

Yes when the tooltip is visible, but when hidden the patch restore the normal refresh rate 


- Iamluc


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6336/#review9630
-----------------------------------------------------------


On Jan. 15, 2011, 3:17 p.m., Iamluc wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6336/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2011, 3:17 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Hi,
> 
> When using a clock applet, seconds are often not visibles. But sometimes you need them.
> This patch shows them in the tooltip of the applet.
> 
> Analog-clock has been updated to refresh the tooltip every seconds.
> If this change is accepted, I could change digital-clock
> 
> Thanks !
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 1214556 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.h 1214556 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/analog-clock/clock.cpp 1214556 
> 
> Diff: http://svn.reviewboard.kde.org/r/6336/diff
> 
> 
> Testing
> -------
> 
> It Works on plasmoidviewer and with a real session
> 
> 
> Thanks,
> 
> Iamluc
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110115/3022bf33/attachment.htm