Review Request: Tasks applet: Make order independent of whether the row count is forced.

[Kåre Särs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5776/#review9601
-----------------------------------------------------------


There is a problem with the new behavior for forced row count. 
Previously the "older" windows/buttons stayed at approximately the same place when new windows where opened/closed, but now more than half of the windows jump back and forth whenever a window is opened or closed. I made a longer explanation of my problem with the new behavior in the bug report that this patch tries to solve. 

Should I maybe re-open the report?

Regards,
  Kåre

- Kåre


On Nov. 6, 2010, 8:58 p.m., Ingomar Wesp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5776/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2010, 8:58 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This should fix <https://bugs.kde.org/show_bug.cgi?id=215231>, but frankly I don't understand why it was done this way in the first place...
> 
> 
> This addresses bug 215231.
>     https://bugs.kde.org/show_bug.cgi?id=215231
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 1190987 
> 
> Diff: http://svn.reviewboard.kde.org/r/5776/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 3 forced rows, 1-5 windows, trunk vs. patched
>   http://svn.reviewboard.kde.org/r/5776/s/550/
> 
> 
> Thanks,
> 
> Ingomar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110110/969f35ed/attachment.htm