Review Request: Option to set no title for the folderview applet

Farhad Hedayati Fard hf.farhad at gmail.com
Sat Feb 26 18:13:13 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100750/
-----------------------------------------------------------

(Updated Feb. 26, 2011, 5:13 p.m.)


Review request for Plasma.


Changes
-------

Edited summary of the review and changed the "Blank title" to "No title" in the configuration dialog for clarity's sake!;)


Summary (updated)
-------

Let the user set a blank label. The label should not take up any space when it is blank.


Diffs (updated)
-----

  plasma/applets/folderview/folderview.h 2241b12 
  plasma/applets/folderview/folderview.cpp f604277 
  plasma/applets/folderview/folderviewDisplayConfig.ui 6568640 

Diff: http://git.reviewboard.kde.org/r/100750/diff


Testing
-------

Works fine here! 


Screenshots
-----------

folderview configuration dialog
  http://git.reviewboard.kde.org/r/100750/s/84/
folderview with blank label
  http://git.reviewboard.kde.org/r/100750/s/85/


Thanks,

Farhad

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110226/9749be70/attachment-0001.htm 


More information about the Plasma-devel mailing list