Review Request: Keyboard navigation for calendar applet

[John Layt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100718/#review1601
-----------------------------------------------------------


Just wondering if we want to have navigation for day selection in the date table as well?  Do we want to make it consistent with the KDatePicker class in kdeui?

KDatePicker has the following key mappings:
Up Arrow = - 1 week (i.e. up one row)
Down Arrow = + 1 week (i.e. down one row)
Left Arrow = - 1 day (i.e. left one column)
Right Arrow = + 1 day (i.e. right one column)
Page Up = - 1 Month
Page Down = + 1 Month

It has no key for +/- year.  KDEPIM doesn't have any key-mappings for its date table widget.

I think if you have both, then moving the day selected in the day table should be the primary navigation, i.e. the arrow keys, with month and year being secondary navigation, i.e. Page Up/Down or perhaps Alt-Arrows or Shift-Arrows?  I like the Home key for Today.

Do we also need key mappings for moving the focus from the date table to the other input widgets (Months = Alt-M, Year = Alt-Y, Date = Alt-D, Week = Alt-W) or is tabbing enough?

I also think Ctrl-C could copy the currently selected date into the clipboard.

- John


On Feb. 22, 2011, 5:42 p.m., Farhad Hedayati Fard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100718/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2011, 5:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Added some keyboard shortcuts through "keyPressEvent"s 
> Key_Right -> next month
> Key_Left -> previous month
> Key_Return and Key_Enter -> today
> Key_PageUp -> next year
> Key_PageDown -> previous year
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=249866.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=249866
> 
> 
> Diffs
> -----
> 
>   libs/plasmaclock/calendar.h f0f1c09 
>   libs/plasmaclock/calendar.cpp 57eecd6 
> 
> Diff: http://git.reviewboard.kde.org/r/100718/diff
> 
> 
> Testing
> -------
> 
> works fine here!
> 
> 
> Thanks,
> 
> Farhad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110223/00bc9b0b/attachment.htm