Review Request: Keyboard navigation for calendar applet

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100718/#review1588
-----------------------------------------------------------

Ship it!


to me is fine, only thing i'm not sure about is the use of the enter key


libs/plasmaclock/calendar.cpp
<http://git.reviewboard.kde.org/r/100718/#comment1365>

    maybe should the Home key instead of return?


- Marco


On Feb. 22, 2011, 5:42 p.m., Farhad Hedayati Fard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100718/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2011, 5:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Added some keyboard shortcuts through "keyPressEvent"s 
> Key_Right -> next month
> Key_Left -> previous month
> Key_Return and Key_Enter -> today
> Key_PageUp -> next year
> Key_PageDown -> previous year
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=249866.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=249866
> 
> 
> Diffs
> -----
> 
>   libs/plasmaclock/calendar.h f0f1c09 
>   libs/plasmaclock/calendar.cpp 57eecd6 
> 
> Diff: http://git.reviewboard.kde.org/r/100718/diff
> 
> 
> Testing
> -------
> 
> works fine here!
> 
> 
> Thanks,
> 
> Farhad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110222/a5551162/attachment.htm