Review Request: KHoliday::HolidayRegionSelector: emit signal when modified
John Layt
john at layt.net
Sun Feb 13 11:27:07 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100619/#review1403
-----------------------------------------------------------
Ship it!
Lookd good!
- John
On Feb. 12, 2011, 4:40 a.m., Romário Rios wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100619/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2011, 4:40 a.m.)
>
>
> Review request for KDEPIM-Libraries and Plasma.
>
>
> Summary
> -------
>
> Makes HolidayRegionSelector emit a signal when something is modified in the widget. Needed for enabling Apply button on plasmaclock config [http://git.reviewboard.kde.org/r/100620/].
>
>
> Diffs
> -----
>
> kholidays/holidayregionselector.h a48823e
> kholidays/holidayregionselector.cpp 6115b2f
>
> Diff: http://git.reviewboard.kde.org/r/100619/diff
>
>
> Testing
> -------
>
> Works fine so far, although I'm not sure if the naming is OK.
>
>
> Thanks,
>
> Romário
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110213/16a352ec/attachment-0001.htm
More information about the Plasma-devel
mailing list