Review Request: Apply buttong for lancelot configuration dialog

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100639/#review1385
-----------------------------------------------------------

Ship it!


looks good; just one small typo in a signal name: Botton instead of Button. correct that little issue and then commit! thanks for the patch..


applets/lancelot/application/LancelotConfig.h
<http://git.reviewboard.kde.org/r/100639/#comment1141>

    small typo: Botton should be Button :)



applets/lancelot/launcher/LancelotApplet.cpp
<http://git.reviewboard.kde.org/r/100639/#comment1142>

    watch for bits of stray whitespace like the indentation on this otherwise empty line :)



applets/lancelot/launcher/LancelotApplet.cpp
<http://git.reviewboard.kde.org/r/100639/#comment1143>

    Botton -> Button


- Aaron J.


On Feb. 12, 2011, 4:33 p.m., Farhad Hedayati Fard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100639/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2011, 4:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Apply buttong for lancelot configuration dialog
> 
> 
> Diffs
> -----
> 
>   applets/lancelot/application/LancelotConfig.h e237363 
>   applets/lancelot/application/LancelotConfig.cpp 8c6cdef 
>   applets/lancelot/launcher/LancelotApplet.cpp e4ec28b 
>   applets/lancelot/launcher/LancelotAppletConfig.h 228cd46 
>   applets/lancelot/launcher/LancelotAppletConfig.cpp 975c21f 
>   applets/lancelot/parts/LancelotPart.cpp fd1b257 
>   applets/lancelot/parts/LancelotPartConfig.h 8395739 
>   applets/lancelot/parts/LancelotPartConfig.cpp 9e98a3c 
> 
> Diff: http://git.reviewboard.kde.org/r/100639/diff
> 
> 
> Testing
> -------
> 
> seems to be working fine
> 
> 
> Thanks,
> 
> Farhad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110212/25536256/attachment.htm