Review Request: Enabling "Apply" button in webslice
Anne-Marie Mahfouf
annma at kde.org
Tue Feb 8 19:59:57 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100609/#review1314
-----------------------------------------------------------
Ship it!
Reviewed. The only missing thing was when you cleared the combo field and wrote your own element and if you use
connect(ui.elementCombo, SIGNAL(editTextChanged(QString)), parent, SLOT(settingsModified()));
it'll work (instead of the currentIndexCHanged signal)
- Anne-Marie
On Feb. 8, 2011, 5:26 p.m., Sinny Kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100609/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2011, 5:26 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Enabled "Apply" button in webslice configuration dialog
>
>
> Diffs
> -----
>
> applets/webslice/plasma/webslice.cpp 08e40a0
>
> Diff: http://git.reviewboard.kde.org/r/100609/diff
>
>
> Testing
> -------
>
> works fine in trunk
>
>
> Thanks,
>
> Sinny
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110208/8ea5d38d/attachment.htm
More information about the Plasma-devel
mailing list