Review Request: Plasma::ScrollWidget: ignore() key press event for keys not handled

Lasse Liehu lliehu at kolumbus.fi
Mon Feb 7 22:11:54 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100586/
-----------------------------------------------------------

(Updated Feb. 7, 2011, 9:11 p.m.)


Review request for Plasma.


Changes
-------

did what was suggested, will push after a few days if there aren't any more comments


Summary
-------

I was just wondering if this is a bug and if this is the right way to solve it, so made a review request.


Diffs (updated)
-----

  plasma/widgets/scrollwidget.cpp b7cc01d 

Diff: http://git.reviewboard.kde.org/r/100586/diff


Testing
-------

Compiles, pressing Esc closes the widgets explorer even when ScrollWidget has focus.


Thanks,

Lasse

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110207/c9b33d12/attachment.htm 


More information about the Plasma-devel mailing list