Review Request: Make condition icons work in NOAA when conditions are translated

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100589/#review1294
-----------------------------------------------------------

Ship it!


instead of storing the result of the translated string in the struct, it would probably be nicer to just store the untranslated version and call i18n on it whenever the translated version is needed. nice catch, though :)


plasma/generic/dataengines/weather/ions/noaa/ion_noaa.cpp
<http://git.reviewboard.kde.org/r/100589/#comment1080>

    should be on the same line: } else {


- Aaron J.


On Feb. 7, 2011, 1:01 a.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100589/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2011, 1:01 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The condition icons didn't always show up correctly because i18n'd condition strings were passed to getConditionIcon(). This tries to fix it, passing it the original strings.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/weather/ions/noaa/ion_noaa.h 84e8d6f 
>   plasma/generic/dataengines/weather/ions/noaa/ion_noaa.cpp 4987968 
> 
> Diff: http://git.reviewboard.kde.org/r/100589/diff
> 
> 
> Testing
> -------
> 
> The correct icons are used on the summary (tested during both day and night) and forecasts, using the "weather" applet and Finnish. The conditions in forecasts' tooltips are still translated.
> 
> 
> Thanks,
> 
> Lasse
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110207/72cea3af/attachment.htm