Review Request: ClockApplet : show seconds in the tooltip

[Iamluc]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6336/
-----------------------------------------------------------

(Updated Feb. 5, 2011, 2:26 p.m.)


Review request for Plasma.


Changes
-------

Hi,

I followed Aaron comments :

* rename ClockTimer to something clearer -> ClockToolTip?
---> Done

* have ClockToolTip subclass both QObject and Plasma::ToolTipContent
--> Done

* move updateToolTip into ClockToolTip, renamed as dataUpdated(const QString &source, const Plasma::DataEngine &data) ;)
--> Done, and move function addTzToTipText() too.

* connect to the dataengine on creation of ClockToolTip
--> Done

* create a ClockToolTip object when toolTipAboutToShow is called
* delete it in toolTipHidden
--> Both done

* pass in the ClockApplet as the parent to ClockToolTip and then in ClockToolTip::dataUpdated, set the mainText and then call Plasma::ToolTipManager::self()->setContent(clockApplet, this)
--> Done


Summary
-------

Hi,

When using a clock applet, seconds are often not visibles. But sometimes you need them.
This patch shows them in the tooltip of the applet.

Analog-clock has been updated to refresh the tooltip every seconds.
If this change is accepted, I could change digital-clock

Thanks !


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/libs/plasmaclock/CMakeLists.txt 1217808 
  /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h 1217808 
  /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 1217808 
  /trunk/KDE/kdebase/workspace/libs/plasmaclock/clocktooltip.h PRE-CREATION 
  /trunk/KDE/kdebase/workspace/libs/plasmaclock/clocktooltip.cpp PRE-CREATION 

Diff: http://svn.reviewboard.kde.org/r/6336/diff


Testing
-------

It Works on plasmoidviewer and with a real session


Thanks,

Iamluc

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110205/5bb5ce4e/attachment.htm