Review Request: Make depedency on kdepimlibs/akonadi-server optional

Aaron J. Seigo aseigo at kde.org
Sat Feb 5 00:31:52 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100568/#review1232
-----------------------------------------------------------


test compiling, and it this doesn't actually work; in fact, it just unconditionally compiles akonadi out of the calendar engine. i'll experiment a bit and see what works.

- Aaron J.


On Feb. 4, 2011, 10:31 p.m., Theo Chatzimichos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100568/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2011, 10:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Previously, kde-workspace/plasma/generic/dataengines/CMakeLists.txt required kdepimlibs compiled with akonadi-server support. The following patch makes it conditional. Patch originally reported in gentoo bug 350850 [1] by fabianoengler at gmail dot com
> 
> [1] https://bugs.gentoo.org/350850
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/CMakeLists.txt 4664a02 
>   plasma/generic/dataengines/calendar/CMakeLists.txt d3d76e6 
>   plasma/generic/dataengines/calendar/calendarengine.cpp 0fdd65d 
> 
> Diff: http://git.reviewboard.kde.org/r/100568/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Theo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110204/5e1d557c/attachment-0001.htm 


More information about the Plasma-devel mailing list