Review Request: Add option to qalculate to show the result in different bases at the same time

[Matteo Agostinelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100533/#review1178
-----------------------------------------------------------

Ship it!


Except for one comment, it looks fine. Can you commit the patch yourself?


applets/qalculate/qalculate_labels.h
<http://git.reviewboard.kde.org/r/100533/#comment984>

    I don't understand why you created the AppletSettings class. Wouldn't it be easier to simply pass a pointer to QalculateSettings in the constructor?
    
    This would save some code duplication. Or am I missing something?


- Matteo


On Feb. 3, 2011, 2:09 p.m., Jef Steelant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100533/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2011, 2:09 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Add the option to qalculate to show the result in binary, octal, decimal and hexadecimal at the same time.
> This only works if the result is an integer
> 
> 
> Diffs
> -----
> 
>   applets/qalculate/qalculate_settings.h cab44e9 
>   applets/qalculate/qalculate_settings.cpp b317e67 
>   applets/qalculate/qalculate_labels.cpp b04c538 
>   applets/qalculate/qalculate_engine.cpp 708f3b2 
>   applets/qalculate/qalculate_labels.h 4cf31e2 
> 
> Diff: http://git.reviewboard.kde.org/r/100533/diff
> 
> 
> Testing
> -------
> 
> built and tested the applet
> 
> 
> Screenshots
> -----------
> 
> settings
>   http://git.reviewboard.kde.org/r/100533/s/63/
> result
>   http://git.reviewboard.kde.org/r/100533/s/64/
> 
> 
> Thanks,
> 
> Jef
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110203/9c0d6c05/attachment.htm