Review Request: Timer: one click to pause/resume, blinks when paused.

[Romário Rios]

> On Feb. 2, 2011, 4:31 p.m., Aaron J. Seigo wrote:
> > do you have a commit account, or do you need someone to commit for you? reason i ask is that i've merged your patch here and made some adjustments to it; if you have a commit account i can send you an updated version of your patch to polish further if you wish and then push, otherwise, i can push it for you.

I have no commit account. Push it.


- Romário


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100521/#review1159
-----------------------------------------------------------


On Feb. 2, 2011, 9:39 a.m., Romário Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100521/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2011, 9:39 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch does some little changes to Timer plasmoid:
>  - Now it takes only one click to start, resume and pause it
>  - It now blinks when paused, making it quicker to determine if it's paused or running
>  - Double-click resets timer
> 
> 
> Diffs
> -----
> 
>   applets/timer/timer.h d191fa3 
>   applets/timer/timer.cpp a09aa4c 
> 
> Diff: http://git.reviewboard.kde.org/r/100521/diff
> 
> 
> Testing
> -------
> 
> As it's a simple modification, I think that it brings no bugs (except by the fact that it says timeout when reseted with double-click).
> 
> 
> Thanks,
> 
> Romário
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110202/5ad29279/attachment.htm