Review Request: Fix plasma popup alignment

Nikita Churaev lamefun.x0r at gmail.com
Sat Dec 31 05:18:19 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103595/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Right-aligned popups are one pixel away from right edge of the screen and top-aligned popups (when the panel is on top) are one pixel inside panel. This is because the bug in QRect, where right() and bottom() value return value that is less than the true value by one. This is a feature-bug that Qt developers aren't going to fix because of compatiability reasons. My patch replaces rect.right() and rect.bottom() with (rect.x() + rect.width()) and (rect.y() + rect.height()) respectively.


Diffs
-----

  plasma/corona.cpp 366a9df 

Diff: http://git.reviewboard.kde.org/r/103595/diff/diff


Testing
-------

Works as expected.


Thanks,

Nikita Churaev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111231/4642d879/attachment.html>


More information about the Plasma-devel mailing list